Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework process to use pull requests instead of issues #310

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Rework process to use pull requests instead of issues #310

wants to merge 2 commits into from

Conversation

nyalldawson
Copy link
Contributor

Summary of changes:

  • Require pull requests for submission of new QEPs instead of issues
  • Document that QEPs which describe policies (such as coding conventions) are MUTABLE, and that proposals can be sent in (via pull requests) to amend and existing QEP. The policies for accepting/rejecting these changes are the same as submission of a new QEP.
  • Add note that PRs should be closed when a proposal is rejected -- this way the PR queue will contain ONLY those submissions currently being discussed

@nyalldawson nyalldawson mentioned this pull request Dec 9, 2024
Merged
@troopa81
Copy link

+1

@alexbruy
Copy link
Contributor

I'm very much in favor of this approach. Just one question: what we will do with the existing QEPs, will we move them to PRs or leave as is?

+1

@nyalldawson
Copy link
Contributor Author

@alexbruy

will we move them to PRs or leave as is?

Well, we have the issue that none of the existing ones were ever really formally approved or voted on, so they are all in a "limbo" state. For this reason I'd lean towards just leaving them as issues and basically start afresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nyalldawson @troopa81 @alexbruy